doxbee-async and doxbee-promise: add side-effects#247
Open
camillobruni wants to merge 8 commits intoWebKit:mainfrom
Open
doxbee-async and doxbee-promise: add side-effects#247camillobruni wants to merge 8 commits intoWebKit:mainfrom
camillobruni wants to merge 8 commits intoWebKit:mainfrom
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
I could not really observe any score changes (might be worth rechecking): After: |
Member
|
I suggest doing similar in |
camillobruni
changed the title
Contributor
Author
|
Weirdly enough I start to see perf differences now
|
| } | ||
| async function dummy_2(a) { | ||
| Queryish.count++; | ||
| } |
Member
There was a problem hiding this comment.
They should avoid using async, and do
function dummy_1() {
Queryish.count++;
return Promise.resolve(undefined);
}
function dummy_2(a) {
Queryish.count++;
return Promise.resolve(undefined);
}
because that's the purpose of this doxbee-promise (not async, that's tested in doxbee-async. testing chain of promises).
Contributor
Author
There was a problem hiding this comment.
I'm still observing quite a diff even with this fixed for JSC (almost none for V8):
Before: 321.0 ± 11.0(3.35%)
After: 309.0 ± 13.0(4.24%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Queryish.count and use it as simple side-effect in the dummy functions.